Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(cli): add cors entry automatically for template package #8035

Merged
merged 5 commits into from
Dec 13, 2024
Merged

feat(cli): add cors entry automatically for template package #8035

merged 5 commits into from
Dec 13, 2024

Conversation

RostiMelk
Copy link
Member

@RostiMelk RostiMelk commented Dec 13, 2024 •
edited
Loading

Description

  • Made a map of all the default ports for all frameworks listen in @vercel/frameworks
  • Using said map to automatically apply a CORS entry per package in template

Fixes GRO-3036

Testing

Run

sanity init --template sanity-io/sanity-template-nextjs-clean

See if http://localhost:3000 was added in Manage for your project

Notes for release

N/A

@RostiMelk RostiMelk requested a review from a team as a code owner December 13, 2024 12:06
@RostiMelk RostiMelk requested review from juice49 and removed request for a team December 13, 2024 12:06
@vercel Vercel
Copy link

vercel bot commented Dec 13, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
page-building-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 1:42pm
performance-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 1:42pm
test-next-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 1:42pm
test-studio ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 13, 2024 1:42pm
1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
studio-workshop ⬜️ Ignored (Inspect) Visit Preview Dec 13, 2024 1:42pm

@github-actions GitHub Actions
Copy link
Contributor

No changes to documentation

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

⚡️ Editor Performance Report

Updated Fri, 13 Dec 2024 13:39:34 GMT

Benchmark reference
latency of sanity@latest		 experiment
latency of this branch		 Δ (%)
latency difference
article (title) 27.0 efps (37ms) 25.0 efps (40ms) +3ms (+8.1%) ✅
article (body) 72.7 efps (14ms) 77.5 efps (13ms) -1ms (-/-%) ✅
article (string inside object) 25.3 efps (40ms) 27.4 efps (37ms) -3ms (-7.6%) ✅
article (string inside array) 24.4 efps (41ms) 25.6 efps (39ms) -2ms (-4.9%) ✅
recipe (name) 55.6 efps (18ms) 55.6 efps (18ms) +0ms (-/-%) ✅
recipe (description) 62.5 efps (16ms) 62.5 efps (16ms) +0ms (-/-%) ✅
recipe (instructions) 99.9+ efps (5ms) 99.9+ efps (5ms) +0ms (-/-%) ✅
synthetic (title) 18.5 efps (54ms) 18.9 efps (53ms) -1ms (-1.9%) ✅
synthetic (string inside object) 18.2 efps (55ms) 19.0 efps (53ms) -3ms (-4.5%) ✅

efps — editor "frames per second". The number of updates assumed to be possible within a second.

Derived from input latency. efps = 1000 / input_latency

Detailed information

🏠 Reference result

The performance result of sanity@latest

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 37ms 40ms 45ms 176ms 151ms 10.6s
article (body) 14ms 15ms 18ms 103ms 208ms 5.0s
article (string inside object) 40ms 44ms 51ms 261ms 233ms 6.9s
article (string inside array) 41ms 43ms 49ms 168ms 138ms 6.9s
recipe (name) 18ms 20ms 23ms 39ms 0ms 7.2s
recipe (description) 16ms 18ms 21ms 27ms 0ms 4.4s
recipe (instructions) 5ms 7ms 9ms 27ms 0ms 3.1s
synthetic (title) 54ms 58ms 64ms 267ms 616ms 14.1s
synthetic (string inside object) 55ms 58ms 65ms 452ms 1009ms 9.0s

🧪 Experiment result

The performance result of this branch

Benchmark latency p75 p90 p99 blocking time test duration
article (title) 40ms 43ms 74ms 194ms 180ms 11.3s
article (body) 13ms 15ms 17ms 180ms 217ms 4.9s
article (string inside object) 37ms 39ms 52ms 294ms 184ms 6.9s
article (string inside array) 39ms 41ms 47ms 86ms 21ms 6.5s
recipe (name) 18ms 20ms 23ms 39ms 0ms 7.4s
recipe (description) 16ms 18ms 19ms 37ms 0ms 4.3s
recipe (instructions) 5ms 6ms 7ms 19ms 0ms 3.0s
synthetic (title) 53ms 56ms 62ms 127ms 248ms 14.6s
synthetic (string inside object) 53ms 56ms 63ms 116ms 201ms 7.6s

📚 Glossary

column definitions

  • benchmark — the name of the test, e.g. "article", followed by the label of the field being measured, e.g. "(title)".
  • latency — the time between when a key was pressed and when it was rendered. derived from a set of samples. the median (p50) is shown to show the most common latency.
  • p75 — the 75th percentile of the input latency in the test run. 75% of the sampled inputs in this benchmark were processed faster than this value. this provides insight into the upper range of typical performance.
  • p90 — the 90th percentile of the input latency in the test run. 90% of the sampled inputs were faster than this. this metric helps identify slower interactions that occurred less frequently during the benchmark.
  • p99 — the 99th percentile of the input latency in the test run. only 1% of sampled inputs were slower than this. this represents the worst-case scenarios encountered during the benchmark, useful for identifying potential performance outliers.
  • blocking time — the total time during which the main thread was blocked, preventing user input and UI updates. this metric helps identify performance bottlenecks that may cause the interface to feel unresponsive.
  • test duration — how long the test run took to complete.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 13, 2024 •
edited
Loading

Component Testing Report Updated Dec 13, 2024 1:38 PM (UTC)

❌ Failed Tests (6) -- expand for details
File Status Duration Passed Skipped Failed
comments/CommentInput.spec.tsx ✅ Passed (Inspect) 1m 12s 15 0 0
formBuilder/ArrayInput.spec.tsx ✅ Passed (Inspect) 14s 3 0 0
formBuilder/inputs/PortableText/Annotations.spec.tsx ✅ Passed (Inspect) 41s 6 0 0
formBuilder/inputs/PortableText/copyPaste/CopyPaste.spec.tsx ✅ Passed (Inspect) 56s 11 7 0
formBuilder/inputs/PortableText/copyPaste/CopyPasteFields.spec.tsx ✅ Passed (Inspect) 0s 0 12 0
formBuilder/inputs/PortableText/Decorators.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/DisableFocusAndUnset.spec.tsx ✅ Passed (Inspect) 16s 3 0 0
formBuilder/inputs/PortableText/DragAndDrop.spec.tsx ❌ Failed (Inspect) 4m 27s 0 0 6
formBuilder/inputs/PortableText/FocusTracking.spec.tsx ✅ Passed (Inspect) 1m 14s 15 0 0
formBuilder/inputs/PortableText/Input.spec.tsx ✅ Passed (Inspect) 3m 1s 21 0 0
formBuilder/inputs/PortableText/ObjectBlock.spec.tsx ✅ Passed (Inspect) 1m 49s 18 0 0
formBuilder/inputs/PortableText/PresenceCursors.spec.tsx ✅ Passed (Inspect) 14s 3 9 0
formBuilder/inputs/PortableText/RangeDecoration.spec.tsx ✅ Passed (Inspect) 42s 9 0 0
formBuilder/inputs/PortableText/Styles.spec.tsx ✅ Passed (Inspect) 29s 6 0 0
formBuilder/inputs/PortableText/Toolbar.spec.tsx ✅ Passed (Inspect) 1m 53s 21 0 0
formBuilder/tree-editing/TreeEditing.spec.tsx ✅ Passed (Inspect) 0s 0 3 0
formBuilder/tree-editing/TreeEditingNestedObjects.spec.tsx ✅ Passed (Inspect) 0s 0 3 0

@RostiMelk RostiMelk requested a review from juice49 December 13, 2024 13:22
juice49
juice49 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Contributor

@juice49 juice49 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvement 🙌.

@RostiMelk RostiMelk added this pull request to the merge queue Dec 13, 2024
Merged via the queue into next with commit 637d345 Dec 13, 2024
58 checks passed
@RostiMelk RostiMelk deleted the feat/cli/add-cors-origin-for-package branch December 13, 2024 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juice49 juice49 juice49 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RostiMelk @juice49